Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit to the pip-compile's header an original command #733

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Emit to the pip-compile's header an original command #733

merged 1 commit into from
Feb 14, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Feb 13, 2019 •
edited
Loading

Uses sys.argv to emit an original command. Closes #726.

Changelog-friendly one-liner: Emit to the pip-compile's header an original command

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added this to the 3.4.0 milestone Feb 13, 2019
@atugushev atugushev changed the title Emit to the pip-compile header an original command Emit to the pip-compile's header an original command Feb 13, 2019
@blueyed
Copy link
Contributor

blueyed commented Feb 13, 2019

Restarted Travis builds - there appears to have been a temporary failure with downloads for py34/py35/pypy/pypy3.

@codecov
Copy link

codecov bot commented Feb 13, 2019 •
edited
Loading

Codecov Report

Merging #733 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage   85.57%   85.81%   +0.24%     
==========================================
  Files          31       31              
  Lines        2128     2122       -6     
  Branches      310      305       -5     
==========================================
  Hits         1821     1821              
+ Misses        236      233       -3     
+ Partials       71       68       -3
Impacted Files Coverage Δ
tests/test_cli.py 97.92% <100%> (-0.02%) ⬇️
tests/test_writer.py 100% <100%> (ø) ⬆️
piptools/writer.py 94.05% <100%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9976139...7d12a5d. Read the comment docs.

@atugushev
Copy link
Member Author

@blueyed yes, thank you! It seems everything is okay now.

@blueyed
Copy link
Contributor

blueyed commented Feb 13, 2019

Great. Will let you / somebody else merge this.

vphilippon
vphilippon approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@vphilippon vphilippon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vphilippon vphilippon merged commit 200bc6b into jazzband:master Feb 14, 2019
@vphilippon
Copy link
Member

pip-tools v3.4.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed blueyed approved these changes

@vphilippon vphilippon vphilippon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@atugushev @blueyed @vphilippon